GitHub user tae-jun reopened a pull request:

    https://github.com/apache/zeppelin/pull/1630

    [ZEPPELIN-1629] Enable renaming folder from the main page

    ### What is this PR for?
    This PR will enable renaming folder from the main page.
    
    I wrote some codes. Hope this PR is the start of folder-based features. 
(e.g folder authorization, folder focused view)
    
    Please check when you have some time!
    Thanks 😄
    
    ### What type of PR is it?
    [Feature]
    
    ### Todos
    * [x] - Fix ConcurrentModificationException of FolderView
    
    ### What is the Jira issue?
    [ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
    
    ### How should this be tested?
    Change folder names!
    
    ### Screenshots (if appropriate)
    
![rename_folder](https://cloud.githubusercontent.com/assets/8201019/20276414/7ba1ee86-aadf-11e6-9180-8f2d0b2b8ed2.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1630.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1630
    
----
commit ca4e1603dc1ced8e20135dc6db113cde64f3fb30
Author: Jun <i2r....@gmail.com>
Date:   2016-11-14T17:50:26Z

    add renaming folder from the main page

commit e7e41c4a865ef129abc9367c5dc157a2686ad29c
Author: Jun <i2r....@gmail.com>
Date:   2016-11-15T12:16:33Z

    Fix ConcurrentModificationException of FolderView, and add more comments

commit 4a3d722883f5869f3cb867bd19f4a48ff4aeb561
Author: Jun <i2r....@gmail.com>
Date:   2016-11-19T09:20:14Z

    Fix awkward insufficient privileges error message

commit cb0ec4f6e48fdb0a5ab2f72da4c033dc06f84d85
Author: Jun <i2r....@gmail.com>
Date:   2016-11-19T09:29:40Z

    Make permission error message more natural

commit e5cd77072922348a5f104eb675214ca5b61802ea
Author: Jun <i2r....@gmail.com>
Date:   2016-11-19T09:37:16Z

    Include note name in permission error message

commit 7f7e6bd30dc78367cc7cc7b59fa89390bc890e48
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-11-20T09:26:29Z

    Change notebook -> note

commit 90182a6910d29cba15e1b82f86016737c1e71aa3
Author: Jun <i2r....@gmail.com>
Date:   2016-11-20T11:05:21Z

    Install Zeppelin to local maven repo after building

commit 11b95eb24cc0e79c564ce4cfd8e0837c823d748b
Author: Jun <i2r....@gmail.com>
Date:   2016-11-20T11:33:42Z

    Revert "Install Zeppelin to local maven repo after building"
    
    This reverts commit 3ad2a2db9d202673068fe3d8b1c1bf5364fe01aa.

commit 757bb10576149f769d37ec37ef46c9b41f4ef22c
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-11-20T18:04:01Z

    Address @AhyoungRyu's suggestions

commit 2f55d05c0db20c0bc2f438fddee0851f4893260f
Author: Jun <i2r....@gmail.com>
Date:   2016-11-23T16:39:07Z

    Fix cannot find symbol error

commit ad84c4c8dd48fdbc741ea8664a615dd055b84bdc
Author: Jun <i2r....@gmail.com>
Date:   2016-11-24T10:48:22Z

    Revert "Fix cannot find symbol error"
    
    This reverts commit 2f55d05c0db20c0bc2f438fddee0851f4893260f.

commit 30ccea9c939953f41379178f73d1291c00d8d415
Author: Jun <i2r....@gmail.com>
Date:   2016-11-24T10:52:02Z

    Fix “cannot find symbol” error by importing `Folder`

commit 0f729b71854fb74dcfc9b7f4f32b2fcece6dbc86
Author: Jun <i2r....@gmail.com>
Date:   2016-11-24T11:14:16Z

    Fix error that not working when a note’s name changed

commit 01e6bc91238a49a5c66b018638db43d2763eb5a1
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-11-28T17:29:04Z

    Fix the error @AhyoungRyu addressed and add more test cases

commit 27fe1eacf7bb1710a834c814bf4c89fab63e5615
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-11-29T11:22:44Z

    Fix the folder test error

commit b719d635dba505e8c2aa7b10a2e577fa967e1805
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-11-30T10:41:30Z

    Fix concurrent modification error

commit af71eddde6ca66491d13eaa92688f3f7b08e9229
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-11-30T11:29:35Z

    Add warning sign if a renamed folder will be merged

commit 5dee99c5149927819f01022a77a0574713b87a2b
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-11-30T16:01:49Z

    Check permission of every notes under the folder which is target of renaming

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to