GitHub user marchpig reopened a pull request:
https://github.com/apache/zeppelin/pull/1733
[ZEPPELIN-1753] Fix blank notename issue
### What is this PR for?
Note ID is displayed on action bar after pressing enter key with blank
notename.
This is because the scope variable for notename is used directly as the
model of input field and it doesn't revert the blank notename back to its
existing name even though the notename was actually not updated to the blank
value. (Temporarily lost notename from scope)
To resolve this issue, I added a variable to `ElasticInputCtrl` for the
model of input field.
This change can always make the notename valid.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1753
### How should this be tested?
Input blank notename on action bar and..
- Check the notename on action bar
- Click 'Export this note' button and check the downloaded json filename.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1753
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1733.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1733
----
commit 25c2ebf6df01b28a551ff7a0f3fc2af1de19db52
Author: Sangwoo Lee <[email protected]>
Date: 2016-12-07T13:34:03Z
Fix blank notename issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
