GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] Visit and switch notebook revisions
### What is this PR for?
This is to enable switching between revisions and being able to set
`Head`/current note to one of those revisions. Currently notes are editable
when switching between them, next step after this PR would be make them
non-editable during revision switches.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - routes and switching revisions
* [x] - set revision button and api
* [x] - test for setting revision
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar, as well as set certain
revisions as shown below
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
commit d1a16e0c6aa226dac4429f0c25b5152ad83b77f8
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T04:59:42Z
create new root and call revision
commit e78add69f41a33619eb1597f4fa09834b7f7070d
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T05:55:18Z
load revision note
commit 105f609801fa9f5a11a116d4dee2baa335f20370
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T06:19:56Z
visit revision when click in dropdown
commit de1cc005537f41983c794dfd7564bc25b39a1c1f
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T06:44:12Z
set current revision name
commit f54f2e82984ca746a92f64c0dc5bcc26d806c937
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T07:16:25Z
fix quotes
commit dd4d2d9691df119172a0fd038e8a5e86974cce93
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T09:49:32Z
fix getNote name change
commit 3f508d470d73afe9e8963d23d34938ed29e2e6f6
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-25T08:29:33Z
fix pass data
commit 9628d64391aec9bceb914af8436a29464a39b679
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-27T11:02:57Z
fix parameters
commit bc15533a39668271aa6604e8ff6ea22afb3cbff9
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T03:58:30Z
add set revision button
commit 30a2ebc25b5dd6902cef30bcbb143d74ae83d1c3
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T04:46:34Z
add ws api on front
commit a657ab5cf18fdece113ad77844135a5afb6ab6ef
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T09:03:19Z
add backend api for setting revision
commit a05a335a2c7d063d286a477eb1f1747d5637db78
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T16:44:40Z
go to note after setting revision
commit b6a0ba2f56535933d4bbd28fda281752e261b8c6
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T04:12:47Z
fix log and checkstyle
commit fae51cb26a556519560d087dff15686ae407159a
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T05:19:47Z
add writer permission check
commit 989c5df1c56a8e3c3cc61663f4414470bfac09b3
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T09:27:46Z
return result status and reload to head if ok
commit 737ce15bd9cd3a2db408f0764cd4012be5874a64
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T09:37:44Z
show error message popup if couldn't set revision
commit c70a20069f8cd70ce97a77a80e4f945b01d60e38
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-02T09:48:18Z
add test
commit f4f9dcc762a342f47cc932cf2be0e716126d1ef2
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-02T10:12:24Z
add broadcast
commit ab7db290eb1e701fb9e01e28f4f5d8a33ce2d0e0
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-02T11:59:32Z
add disable flag for setting revision
only when enabled when in certain revision
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
