GitHub user marchpig opened a pull request:

    https://github.com/apache/zeppelin/pull/1777

    [ZEPPELIN-1831] Fix paragraph control dropdown alignment

    ### What is this PR for?
    Paragraph control dropdown is displayed outside when the browser width is 
small.
    To fix this problem, this PR uses `.dropdown-menu-right` bootstrap css 
class to make the dropdown right aligned with its parent so that it is always 
displayed inside of the paragraph.
    
    ref. http://v4-alpha.getbootstrap.com/components/dropdowns/#menu-alignment
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1831
    
    ### How should this be tested?
    Decrease browser width and click a paragraph control icon.
    
    ### Screenshots (if appropriate)
    [Before]
    
![paragraph-dropdown-before](https://cloud.githubusercontent.com/assets/17305893/21269800/87931b94-c3f7-11e6-9c5c-94de7fa32a46.png)
    
    [After]
    
![paragraph-dropdown-after](https://cloud.githubusercontent.com/assets/17305893/21269807/8dc1d6fe-c3f7-11e6-84d7-eed4ca38670a.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1831

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1777
    
----
commit 1ab98f4b4eac09772b9efc1511c05857d462fcd4
Author: Sangwoo Lee <marchpi...@gmail.com>
Date:   2016-12-16T16:21:41Z

    Fix paragraph control dropdown alignment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to