[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

[tae-jun]

Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/1730
  
    I changed `empty trash`, `remove folder permanently`, and `remove note 
permanently` icons to `X`. I'm not sure this is the best icon for it ^^; but we 
can change later when we find a suitable icon.
    #### Empty trash icon:
    
![image](https://cloud.githubusercontent.com/assets/8201019/21286529/11d306dc-c49a-11e6-9960-a87f7c4d2f1c.png)
    #### Remove folder permanently icon:
    
![image](https://cloud.githubusercontent.com/assets/8201019/21286535/21cb26a0-c49a-11e6-87d0-1e592484af1f.png)
    #### Remove note permanently icon:
    
![image](https://cloud.githubusercontent.com/assets/8201019/21286537/2b29c4fe-c49a-11e6-96b8-ec9cc771aa55.png)
    
    And I've been thinking about attaching the time stamp to all, but there are 
some reasons I worry about:
    * It makes folder name too long. It's not good to see. So, I also removed 
infix ` removed at `. 
    * MacOS also only attaches the time stamp to duplicated folder names. So, 
only attaching the time stamp to duplicated ones is more familiar to users, I 
think.
    
    Now, a duplicated folder name looks like this:
    
![image](https://cloud.githubusercontent.com/assets/8201019/21286783/b912dca0-c4a0-11e6-8ce9-04b4c9d3c40e.png)
    
    What do you think @AhyoungRyu?
    Thanks for the review 😄 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---