GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1781

    Followup for ZEPPELIN-1785

    ### What is this PR for?
    After #1745, zeppelin fail to launch in windows. 
https://issues.apache.org/jira/browse/ZEPPELIN-1785?focusedCommentId=15754688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15754688
    
    This due to the shell script difference between windows and *nix. This PR 
just remove the checking for ZEPPELIN_NOTEBOOK_DIR as it would be created in 
JVM side if the dir is not existed. I also remove it from  zeppelin.sh for *nix 
as well.
    
    
    ### What type of PR is it?
    [Hot Fix |]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1785
    
    ### How should this be tested?
    Tested it manually in windows and mac. Zeppelin can launch successfully on 
windows/mac even when the notebook dir doesn't exist. 
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin Followup_ZEPPELIN-1785

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1781
    
----
commit 2c7c719583cbfcacb27a7340d8561abca51eb6ae
Author: Jeff Zhang <zjf...@apache.org>
Date:   2016-12-19T07:12:04Z

    HotFix for zeppelin.cmd

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to