GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1775
[ZEPPELIN-1745] View revisions in non-editable mode
### What is this PR for?
This is to make view of revisions non-editable
### What type of PR is it?
Improvement
### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys
### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)
### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to
modify note
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
feat/revision-view
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1775
----
commit 9db56ce63910d9738b2f7a874cab8e6570f16b49
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T04:20:22Z
change var name revisionDisabled -> revisionView
commit cd4e37072c8e154d551ed0c3361fff719a8d55ae
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:10:26Z
disable run all
commit 4f12a5bff226e7f871e810a254daeaea58f3b395
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:12:09Z
disable clear output
commit 5c9dd80a94ed990a41251c105a9c7b697bf3221c
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:18:02Z
disable clone note
commit 49f0e15ff215e925657b2972ec7f239b64c2e104
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:19:21Z
disable export note
commit a05f355a96feb1cf7a424cda6775862439b974b0
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:22:14Z
disable revision commit
commit dbb680cda6df168030bda2eebcbcba1ca32c0b62
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:24:16Z
disable remove note
commit 00a0a247162791f2d332c0049ea469008b0e2177
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:25:42Z
disable scheduler
commit ee87a53805f9af9c657db24938e47ea409cfa258
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T04:21:51Z
disable + new paragraph
commit 9d73be4f8447596600b6f9723922d521f66d337f
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T04:26:37Z
don't show paragraph settings menu
commit 2cf28dce40b14bed547fe5727850093ef490a258
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T05:09:27Z
don't show run/cancel on paragraph
commit 45a11cf45e0531e3159eb399e0b3d07a305ccbc4
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T08:00:39Z
make paragraph title non-editable
commit e61e049efdf53b8c386f60f64444a11be3e43518
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T05:20:07Z
disable editor editing
normally it should be done on change of .revisionView however at that time
editor isn't loaded yet
commit e78599cc82fc22e253ba4f52dcdd7482133bf6f1
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:11:50Z
disable hotkeys
commit 464d19f3b3cef37def095f8dd30e35c208041e6e
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:32:15Z
disable editing note name
commit 4c71b6def9164f0675b2f9483a88fa01a7a26483
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:41:34Z
disable show/hide code in note action-bar
commit ebf2d2fd55a2042d65579ae0149a98a6de07b944
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:43:20Z
disable show/hide output in note action bar
commit 9b42e0ef9a503e8eebb3ca0fa9673ea10097e61e
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:47:25Z
don't show paragraph level hide editor button
commit 6963abae404e4aadae6445c8990e23ba52d44183
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:48:13Z
don't show paragraph level hide output buttton
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
