GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/1736

    [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut

    ### What is this PR for?
    Currently, keyboard shortcuts can be only seen by keyboard icon.
    It'll be very comfortable if keyboard shortcuts are showing the menu of 
paragraph.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
     - [x] Add the keyboard shortcut of Link this paragraph
     - [x] Update CI(Selelium) Test case
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1757
    
    ### How should this be tested?
    Click to paragraph menu. I tested on Ubuntu.
    
    ### Screenshots (if appropriate)
    [before]
    ![screenshot from 2016-12-08 
14-52-35](https://cloud.githubusercontent.com/assets/8110458/20999795/77b93d78-bd5a-11e6-9d15-0ea1995c2cf5.png)
    
    [after]
    
![image](https://cloud.githubusercontent.com/assets/8110458/21339558/a759e6e6-c6c3-11e6-920f-ebd264a60f0d.png)
    
    
![z1736](https://cloud.githubusercontent.com/assets/8110458/21339628/25222340-c6c4-11e6-824e-7ef059b90eb9.gif)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1757

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1736
    
----
commit 9ee5cc9f72f381be02d08b1cef02195b8156cfad
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-08T06:17:20Z

    [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut

commit e5b6cc0f892678451dc0ddecff5fc642480ffe8c
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-08T06:19:57Z

    [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut

commit 0b54bfdad92ff7e432602d14b496b41a2db001ac
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-13T06:37:36Z

    [ZEPPELIN-1757] changed CI test

commit a8332886dfe90d01e4b2871d7685518b527175a0
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-13T07:27:26Z

    [ZEPPELIN-1757] changed CI test

commit 76c75b0ff2aec591fc6bae97a176bd1c8a86b35e
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-13T08:23:03Z

    [ZEPPELIN-1757] changed selenium CI test

commit ff96071ec765c94ca1cdd213b47abe8207baa10c
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-13T09:08:19Z

    [ZEPPELIN-1757] changed selenium CI test

commit b34a5b551beb0d332e6036caadbc7a8ba9b12a8b
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-13T11:29:39Z

    [ZEPPELIN-1757] changed selenium CI test

commit cc84b08257f4123d241ff34a664e454c48fbaa8f
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-20T05:01:32Z

    [ZEPPELIN-1757] add shortcut key to tooltip and Link this paragraph

commit cdd34ef7cbdfef810623b92a2e3192315092447a
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-20T07:42:16Z

    [ZEPPELIN-1757] update Selelium Test case

commit 5b84f23ecef0dabff0aaf4da78580f620f83ef04
Author: soralee <sora0...@nflabs.com>
Date:   2016-12-27T06:07:59Z

    for aligned shortcut key text

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to