[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

Fri, 30 Dec 2016 03:43:27 -0800 

GitHub user tae-jun reopened a pull request:

    https://github.com/apache/zeppelin/pull/1730

    [ZEPPELIN-1736] Introduce trash & enable removing folder

    ### What is this PR for?
    
![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
    This PR introduces the trash! (which is essential, I think ^^;)
    
    I added basic operations of the trash:
    #### Added operations of trash
    * `Move` a folder to the trash
    * `Move` a note to the trash
    * `Restore` a folder
    * `Restore` a note
    * `Remove` a folder in the trash for good
    * `Remove` a note in the trash for good
    * `Empty` the trash
    * `Restore all` in the trash
    * `Move` a note to the trash from the notebook view
    * `Remove` a note to the trash for good from the notebook view
    * If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)
    
    
    ### What type of PR is it?
    [Feature]
    
    ### Future work
    Maybe it would be better if notebook view notices that a note is in the 
trash.
    
    ### What is the Jira issue?
    [ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)
    
    ### How should this be tested?
    * Build this PR
    * Move some folders or notes to the trash
    * Restore them
    * Empty the trash
    * Restore all notes in the trash
    * Remove folders or notes in the trash
    * Remove a folder which has the same folder name in the trash
    
    ### Screenshots (if appropriate)
    ## Move, restore, remove a note from the main page
    
![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)
    
    ## Move, restore, remove a folder from the main page
    
![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)
    
    ## Move, remove a note from the notebook view
    
![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)
    
    ## Restore, empty the trash
    
![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)
    
    ## Suffix current date if the folder exists in the trash
    
![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1730
    
----
commit a010f8724329efe198bcb9406c8ed5892deea7d7
Author: Jun Kim <[email protected]>
Date:   2016-12-06T11:21:38Z

    Introduce trash & removing folder

commit 6fc1846a044cc27ef5e5c69519b54cead25034a2
Author: Jun Kim <[email protected]>
Date:   2016-12-06T12:54:54Z

    Satisfy style check

commit bf4641007ea209a44278514f0c5251b4a5732ac1
Author: Jun Kim <[email protected]>
Date:   2016-12-06T12:55:19Z

    Remove if note is in the trash from the notebook view

commit 7ab945fbfef0da222e2291d32863931a81933edd
Author: Jun Kim <[email protected]>
Date:   2016-12-07T17:12:51Z

    Use trash folder id provided by constant service

commit b4f42b26f781c341a1d035e685024bef229370ba
Author: Jun Kim <[email protected]>
Date:   2016-12-07T17:14:00Z

    Change “for good” -> “permanently”

commit 43cf08bac15f1e979a2ff6f1e1b7d21f9e07c62a
Author: Jun Kim <[email protected]>
Date:   2016-12-07T17:15:51Z

    Make the order of the trash folder last

commit 3490494a087f16e6d4b12101e829da571756e27f
Author: Jun Kim <[email protected]>
Date:   2016-12-08T15:28:15Z

    Restore a folder without removed date

commit d7131799c9f614a986400e8d9ee7830fb3d602a7
Author: Jun Kim <[email protected]>
Date:   2016-12-08T15:42:26Z

    Define isTrash function on notebook controller

commit 25d7b8f633639b9335b7eefd22e53e7b9b8a9070
Author: Jun Kim <[email protected]>
Date:   2016-12-08T15:59:10Z

    Define notebook list button style

commit cb84473046b40e229e5f95f00608805b676f6e06
Author: Jun Kim <[email protected]>
Date:   2016-12-08T16:03:39Z

    Fix stylecheck issue

commit 2407844911184e6cd750d20b7ad76d5dd9c11a8e
Author: Jun Kim <[email protected]>
Date:   2016-12-11T13:52:14Z

    Fix white space bug @marchpig addressed

commit 5a33b176fc4d79fb47e033e438ed49c2c6b728dc
Author: Jun Kim <[email protected]>
Date:   2016-12-11T14:07:37Z

    Change selenium test codes affected by chaging ‘removeNote’ button to 
‘moveToTrash’

commit 1381727174d38cd5103b63131bd26b2c7b2705c3
Author: Jun Kim <[email protected]>
Date:   2016-12-17T12:38:45Z

    Change remove permanently icons, remove folder conflict infix

commit 35131b39307e25b024f86b1f71d403dbc7a69b34
Author: Jun Kim <[email protected]>
Date:   2016-12-22T15:04:59Z

    Show trash folder icon at navbar

commit 3b77c579e8555d5948a074188b2fb38c464f7104
Author: Jun Kim <[email protected]>
Date:   2016-12-22T17:18:41Z

    Hide rename, clear output buttons

commit 9e25b3172b2a9a6b2195ce7e8e7b920dfb93726b
Author: Jun Kim <[email protected]>
Date:   2016-12-30T11:20:21Z

    show trash icon after searching notes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to