GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter.
And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form
[FolderName/NoteName] like below. It would be nice to show folder icon and note
icon as previous status.
2. When using the filter, some functions and icons next to note and folder
are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I
was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when
using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of
your notes. It should be same appearance.
- **[Test 2]** When using the filter, check the notes, some icon and
function next to note and folder should be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It should be
appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit c21c9d33138e7a4e48d42c1f46862eebc75cad02
Author: soralee <[email protected]>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 4ef7f8d6af372355d609a606cfeb12592f14584c
Author: soralee <[email protected]>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
