[GitHub] zeppelin pull request #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode ...

[1ambda]

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/1854

    [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip text

    ### What is this PR for?
    
    Currently the tooltip for personalized mode is quite confusing. Since
    
    - tooltip text is {{Collaboration mode}}
    - and when i click the icon, dialog tell me {{Do you want to personalized 
your analysis?}}
    
    **Tooltips should tell us what we can do instead of just stating current 
state as other tooltips do**
    
    <img width="211" alt="confusing-1" 
src="https://cloud.githubusercontent.com/assets/4968473/21708295/6ae778e0-d41a-11e6-8aa6-a30a3cebec74.png";>
    
    <img width="472" alt="confusing-2" 
src="https://cloud.githubusercontent.com/assets/4968473/21708297/6e30f01c-d41a-11e6-991e-504aadfa5dc9.png";>
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    Nothing
    
    ### What is the Jira issue?
    
    [ZEPPELIN-1912](https://issues.apache.org/jira/browse/ZEPPELIN-1912)
    
    ### How should this be tested?
    
    1. Enable shiro and login
    2. Check the tooltip text while switching modes
    
    ### Screenshots (if appropriate)
    
    #### After
    
    <img width="154" alt="switch-2" 
src="https://cloud.githubusercontent.com/assets/4968473/21708341/d869d6c4-d41a-11e6-808f-5eadd6f7727a.png";>
    
    <img width="234" alt="switch-1" 
src="https://cloud.githubusercontent.com/assets/4968473/21708305/7c5cef24-d41a-11e6-8524-993a880300f2.png";>
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-1912/enhance-personalized-tooltip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1854
    
----
commit 9aee7472f257d086dddc84d32b061e3aa7437d14
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-06T05:12:24Z

    fix: Improve perosnalized mode tooltip text

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---