GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1848

    [ZEPPELIN-1812] Ace editor show/hide problem.

    ### What is this PR for?
    When editor hide is on and page refresh then editor is gone.
    I was solve this problem.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1812
    
    ### How should this be tested?
    1. hide to editor mode on in paragraph configure.
    2. page refresh (f5)
    3. enable to show editor mode in paragraph configure.
    4. if show editor then is correct.
    ### Screenshots (if appropriate)
    #### before
    
![badeditor](https://cloud.githubusercontent.com/assets/10525473/21677078/62136de2-d2ed-11e6-9418-0be4453fd839.gif)
    
    #### after
    
![goodeditor](https://cloud.githubusercontent.com/assets/10525473/21677092/6c8d97e8-d2ed-11e6-8966-a3b7af60c231.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-1812

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1848.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1848
    
----
commit b7cd700eccfd2ed51f29c17285bad36579c02208
Author: cloverhearts <cloverhearts...@gmail.com>
Date:   2017-01-05T10:09:38Z

    fixed ace editor hide problem

commit 037993d23257b31836ad59d8805540d30dd1c420
Author: cloverhearts <cloverhearts...@gmail.com>
Date:   2017-01-06T04:09:33Z

    fixed test case

commit c3efea2b93ce2defcf822ef380b5f66cc349c81a
Author: cloverhearts <cloverhearts...@gmail.com>
Date:   2017-01-06T05:25:26Z

    Revert "fixed test case"
    
    This reverts commit 037993d23257b31836ad59d8805540d30dd1c420.

commit 4750e6fce66e95265f2eea1ad45672a673ccd2a9
Author: cloverhearts <cloverhearts...@gmail.com>
Date:   2017-01-06T08:39:22Z

    fix testcase

commit d10d53d6c578d4f0749402a38c9e9337fb68e702
Author: cloverhearts <cloverhearts...@gmail.com>
Date:   2017-01-06T08:42:06Z

    add element null check

commit 9c5ee63e3217e25d92080101cd21baff542ec113
Author: cloverhearts <cloverhearts...@gmail.com>
Date:   2017-01-06T09:22:46Z

    add size check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to