GitHub user DrIgor opened a pull request:

    https://github.com/apache/zeppelin/pull/1911

    [ZEPPELIN-1972] Preserve context classloader

    ### What is this PR for?
    `IMain.interpret` changes current thread's context classloader. It may 
cause different issues and definitely is the reason of 
[ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738) test 
failures.
    
    It's a known scala bug. See https://issues.scala-lang.org/browse/SI-9587
    
    As a workaround we need to save and restore context classloader manually
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1972](https://issues.apache.org/jira/browse/ZEPPELIN-1972)
    
    ### How should this be tested?
    Run ignite interpreter test and ignite sql interpreter test in the same 
thread
    ```
    mvn test -pl ignite -am -Pscala-2.11 
-Dtest=org.apache.zeppelin.ignite.IgniteInterpreterTest#testInterpret,org.apache.zeppelin.ignite.IgniteSqlInterpreterTest#testSql
 -DfailIfNoTests=false
    ```
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1972

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1911.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1911
    
----
commit 35c5abdc7f006c2ce4b0097cdd5192ef27293cd4
Author: Igor Drozdov <igor_droz...@epam.com>
Date:   2017-01-16T09:19:35Z

    Preserve context classloader
    
    IMain.interpret changes current thread's context classloader.
    It's a scala bug.
    
    As a workaround we need to save and restore context classloader manually

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to