GitHub user cloverhearts reopened a pull request: https://github.com/apache/zeppelin/pull/1864
[ZEPPELIN-1921] missing close in closeAndRemoveInterpreterGroup method ### What is this PR for? The problem is that some code in the closeAndRemoveInterpreterGroup method of InterpreterSetting partially closes. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1921 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-1921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1864.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1864 ---- commit 0ebed445e44dff3538e546e4dae92c76851d9033 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-07T09:27:51Z fixed missing for close commit 2188b1bbe93b32138c9449c56a8b493d1bc7b874 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-07T11:01:21Z change Linkedlist to LinkedHashSet commit 59c9c761b3d5e1dc16a5bf330be082b0fcac93dc Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-08T05:34:03Z implement testcase commit 546ee8549e0c10cdc7535e5b9462f945ad888394 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-08T05:34:40Z Revert "change Linkedlist to LinkedHashSet" This reverts commit 2188b1bbe93b32138c9449c56a8b493d1bc7b874. commit e25f3114956b9e7fc53d32615a76a0febc05463c Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-08T06:25:47Z interpreter test case and replace logic commit 2482be6c83ce4b784af20c9f69b4097d46cef035 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-08T06:42:05Z container method -> isEqualInterpreterKey method commit b0a93969df652900cf9829505322a0fd9b2091fa Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-08T07:16:07Z test case and replace logic commit a105adf68b09d0be535cd5c55e69132b2892ec74 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-09T08:48:04Z Merge branch 'master' into ZEPPELIN-1921 commit 22473a219680b11d49649493b4615f39e32e7f00 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-16T06:51:16Z change return logic commit ca9ecfd46d805a2a07087a3e607435eb96c0ac22 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-17T19:28:51Z Merge branch 'master' into ZEPPELIN-1921 # Conflicts: # zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java commit d12ec573ea4fe167d85ac259bf52a2dee8bcae2d Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-17T20:12:51Z missing brace commit 6a2051c751d35983b5dbd804187752a9ae8b858f Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-17T20:20:30Z method name change (master rebase) commit 6b86dfd0ba84641a30ff5ad8e92329eeb2ceb30f Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-18T05:38:20Z compare logic change commit e21287f1ea3b6c4c24c360c824f5b8c25fe4f8c4 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-18T05:47:37Z apply other side commit f39212c2d8f0dd0c030d4036ef841f6adb25e675 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-20T10:49:02Z fixed equals logic commit 4ac76cfc5f79f7e12fd384741bdb9ed6df847951 Author: cloverhearts <cloverhearts...@gmail.com> Date: 2017-01-20T21:38:17Z Merge branch 'master' into ZEPPELIN-1921 ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---