GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/1983

    [ZEPPELIN-1808] disable shortcut key of window created by link this 
paragraph

    ### What is this PR for?
    If using a `Link this paragraph`, new window works the keyboard shortcut. 
    Keyboard shortcut should not work in "Link this paragraph" URL.
    
    ### What type of PR is it?
    [ Improvement ]
    
    ### What is the Jira issue?
    [ZEPPELIN-1808](https://issues.apache.org/jira/browse/ZEPPELIN-1808)
    
    ### How should this be tested?
    1. Click `Link this paragraph` or Use `Ctrl+Alt(command)+w` in a paragraph.
    2. Use some keyboard shortcut in new window which is created by `Link this 
paragraph`.
    3. Check text and title shape of the paragraph.
    
    ### Screenshots (if appropriate)
    [ Before ]
    * When trying to use keyboard shortcut in new paragraph.
    
![1808_b](https://cloud.githubusercontent.com/assets/8110458/22680039/6020a24a-ed49-11e6-9d52-accfa4982252.gif)
    
    * Text and title are misaligned
    
![1808_b](https://cloud.githubusercontent.com/assets/8110458/22680223/3ac4f090-ed4a-11e6-972d-e863ce81a187.png)
    
    
    [ After ]
    
![image](https://cloud.githubusercontent.com/assets/8110458/22680134/dc18169e-ed49-11e6-9190-f5a9ae20c745.png)
    
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1808_dont_shortcut

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1983
    
----
commit dd563a2efddb0ceec4bd9593dc96a913ab0aa779
Author: soralee <sora0...@zepl.com>
Date:   2017-02-06T17:15:14Z

    [ZEPPELIN-1808] disable shortcut key of window created by link this 
paragraph

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to