GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortable to create test
- it's hard to figure which source is related with this test file.
```javascript
// we have to import like this...
import TableData from '../../../src/app/tabledata/tabledata.js';
```
### What type of PR is it?
[Improvement]
### Todos
* [x] - Fix karma conf
* [x] - Move test files
### What is the Jira issue?
[ZEPPELIN-2086](https://issues.apache.org/jira/browse/ZEPPELIN-2086)
### How should this be tested?
- Execute `npm runt test`
- You should see this message like before
```
webpack: Compiled successfully.
09 02 2017 12:36:01.876:INFO [karma]: Karma v1.3.0 server started at
http://localhost:9002/
09 02 2017 12:36:01.878:INFO [launcher]: Launching browser PhantomJS with
unlimited concurrency
09 02 2017 12:36:01.888:INFO [launcher]: Starting browser PhantomJS
09 02 2017 12:36:02.372:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: Connected
on socket /#BkEJkZGwxoc6HMA7AAAA with id 42992167
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 37 of 70 SUCCESS (0 secs / 0.236
secs)
LOG: function TableData(columns, rows, comment) { ... }
LOG: function TableData(columns, rows, comment) { ... }
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 70 of 70 SUCCESS (0.26 secs /
0.352 secs)
```
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2086/refactor-web-test-dirs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1995.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1995
----
commit a492e64f78ca3e35ab920bd757604df5fd928932
Author: 1ambda <[email protected]>
Date: 2017-02-09T03:26:08Z
fix: test file pattern in karma.conf.js
commit 30c91abab8bb6b721fef6e2762022c6c1f74b5a5
Author: 1ambda <[email protected]>
Date: 2017-02-09T03:26:27Z
fix: Move test files into src/ while renaming
commit a2d2d11ff8e2a78e06885d6b9f0a86bad09ce855
Author: 1ambda <[email protected]>
Date: 2017-02-09T03:26:34Z
fix: Remove useless jshintrc
commit 3aa0b5df5a20d7578201931f6983ac917705567f
Author: 1ambda <[email protected]>
Date: 2017-02-09T03:30:34Z
fix: Move karma.conf file to top-level
commit 7367aeb9aa82f236f05433388d702a78f6d051e5
Author: 1ambda <[email protected]>
Date: 2017-02-09T03:30:45Z
fix: Import path in tabledata.test.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
