GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2006

    [ZEPPELIN-2099] Add NPM link for helium pkgs published in npm

    ### What is this PR for?
    
    Add NPM link for helium pkgs published in npm while coloring grey for local 
packages to distinguish easily.
    
    ### What type of PR is it?
    [Improvement]
    
    ### TODOs
    
    - [x] Add link to published npm packages
    - [x] Grey color for local to distinguish
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2099](https://issues.apache.org/jira/browse/ZEPPELIN-2099)
    
    ### How should this be tested?
    
    1. Build Zeppelin using ` mvn clean package -Phelium-dev-Pexamples 
-DskipTests;` for creating helium examples.
    2. Open the `/helium` page
    
    - click the name of published npm package.
    - check color of local package. 
    
    ### Screenshots (if appropriate)
    
    #### NPM Link
    
![npm-link](https://cloud.githubusercontent.com/assets/4968473/22859688/2d0322f6-f128-11e6-83db-b1a0013a04bf.gif)
    
    #### Local Package Name Color
    
![image](https://cloud.githubusercontent.com/assets/4968473/22859724/f36866e4-f129-11e6-8bf2-dfd5a69b536e.png)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2099/adding-npm-link-to-helium-pkg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2006
    
----
commit 3ff460eae614290ada34ff6ad4a897e28ffd280d
Author: 1ambda <1am...@gmail.com>
Date:   2017-02-12T04:33:49Z

    feat: Add npm link for helium pkgs published in npm

commit d4ac92373b3ed2a9d12d861340703b15cbd45342
Author: 1ambda <1am...@gmail.com>
Date:   2017-02-12T04:47:06Z

    feat: Add color to local packages

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to