Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/2034
  
    
    > Leemoonsoo 3 hours ago Member
    I think void close(String sessionId) supposed not necessarily terminate 
process while an interpreter process can have multiple sessions.
    
    I also agree with @Leemoonsoo's opinion.
    The "close () method" should only serve to close the session.
    "Close () method" To force a process termination call,
    It is very effective in this issue, but it has the potential to become a 
problem in the future.
    (Especially about user management functions or roles for sessions)
    
    **In my personal opinion, we need to identify this as an increase and a 
decrease in the erroneous reference.**
    In the past we actually had a separate code to forcefully terminate the 
"Remote Interpreter".
    
    Ref Code (destroy) : 
https://github.com/apache/zeppelin/blob/branch-0.6/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java#L204
    remove PR : 
https://github.com/apache/zeppelin/commit/c6c67d7b112eceb36846e03207cb9c37519f1730
    
    Actually this is very similar to the current code.
    Actually, this problem is almost solved by recovering to the point of the 
code of the corresponding PR or adding the content of the problem.
    However, in my opinion, the essence of this problem is not a "zombie 
process"
    I think the **session management is wrong.**
    If you do not know what to do with the destroy () method, you can simply 
restore it.
    But, in my humble opinion, the deletion of the "destory () method" is not 
the wrong way.
    Of course I also need more specific research on this part.
    
    what do you think?
    
    Sorry. @prabhjyotsingh 
    I think you presented a good solution.
    But I think I have to approach this problem carefully.
    Please tell us your opinion at any time.
    Thank you. Have a good day.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to