[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][ZEPPELIN-2110] Sortable Helium ...

Sun, 19 Feb 2017 09:42:46 -0800 

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2037

    [ZEPPELIN-2109][ZEPPELIN-2110] Sortable Helium pkgs & Introduce 
"INTERPRETER" type

    ### What is this PR for?
    
    * Make Helium pkgs sortable
    For now, we have 3 types of Helium packages: `VISUALIZATION`, `SPELL` and 
`APPLICATION`.
    `VISUALIZATION` and `SPELL` type of pkgs can be published [NPM 
registry](https://www.npmjs.com/). Likewise, `APPLICATION` type pkg can be 
registered in [Maven central repository](http://search.maven.org/). 
    But all available Helium packages are not sorted and shown in random order 
in Helium menu.
    To do this, I put "NPM Packages" & "Maven Artifacts" button at top-right 
corner of Helium menu. 
    
    * Introduce "INTERPRETER" type
    As a first step of [ZEPPELIN-1993: Install interpreter from Helium 
menu](https://issues.apache.org/jira/browse/ZEPPELIN-1993), I added 
`INTERPRETER` type as a new Helium pkg type. Like 
[ZEPPELIN-1973](https://issues.apache.org/jira/browse/ZEPPELIN-1973) did, we 
can retrieve Maven artifact(which has `zeppelin-interpreter` as its dependency) 
info and save it to Helium online registry as well. 
    For more detailed explanation, please see 
[ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) and 
[ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110)'s 
description.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - address feedback
    
    ### What is the Jira issue?
    * [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109) : 
Make Helium packages sortable in Helium menu
    * [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110) : 
List community & 3rd party interpreter registered at Maven central repo in 
Helium menu 
    
    ### How should this be tested?
    To see how `INTERPRETER` type can be shown in Helium menu,
    
    1. Replace temporarily 
[ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46)
 with [this 
url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium-test.json)
    
    2. Build \w below command and restart
    ```
     $ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, 
zeppelin-interpreter'
    ```
    
    3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse 
`localhost:9000`
    ```
    $ yarn run dev:helium
    ```
    
    4. Go to Helium menu
    ### Screenshots (if appropriate)
     - How's it look?
    
![record](https://cloud.githubusercontent.com/assets/10060731/23104377/1b51a706-f710-11e6-90cc-841a9c1d6616.gif)
    
     - Package selection by types (NPM pkgs(`SPELL` or `VISUALIZATION`)?  or 
Maven artifacts(`APPLICATION` or `INTERPRETER`)?)
    <img width="300" alt="screen shot 2017-02-20 at 1 59 37 am" 
src="https://cloud.githubusercontent.com/assets/10060731/23104398/84721784-f710-11e6-80fa-6c7730ab88ea.png";>
    <img width="300" alt="screen shot 2017-02-20 at 1 59 46 am" 
src="https://cloud.githubusercontent.com/assets/10060731/23104401/85c02450-f710-11e6-90bb-e98dbe5af70d.png";>
    
     - Disabled "Enable" button until 
[ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) is resolved
    <img width="580px" alt="screen shot 2017-02-20 at 2 03 23 am" 
src="https://cloud.githubusercontent.com/assets/10060731/23104412/c95dccb2-f710-11e6-9602-4159c7182e64.png";>
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2109

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2037.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2037
    
----
commit 6f099661a93ca49ca6e627f56b477f84c3cf157d
Author: AhyoungRyu <[email protected]>
Date:   2017-02-19T16:46:05Z

    Add img files

commit 51efa29b36935e5d19894c9c957db7e8247c2cf6
Author: AhyoungRyu <[email protected]>
Date:   2017-02-19T16:47:17Z

    Add 'INTERPRETER', 'APPLICATION' as helium pkg types

commit 38c2e03517521907036f204c7d95510113296b58
Author: AhyoungRyu <[email protected]>
Date:   2017-02-19T16:51:00Z

    Enable Helium pkg type sortable

commit 34ed7cd4541835903e8161998b13bc06469942b6
Author: AhyoungRyu <[email protected]>
Date:   2017-02-19T17:12:16Z

    Remove console.log

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to