GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2122

    Jdbc interpreter sometime doesn't show detailed error message

    ### What is this PR for?
    Zeppelin's JDBC interpreter sometimes doesn't show detailed error message 
on the notebook ui. It shows only plain "ERROR" text near run button in case of 
failure. User has to check JDBC interpreter log file in order to see a detailed 
error message.
    
    This is mostly in case of incompatible JAR and I see errors mentioned below;
    ```
    java.lang.NoSuchMethodError: 
org.apache.curator.utils.ZKPaths.fixForNamespace(Ljava/lang/String;Ljava/lang/String;Z)Ljava/lang/String;
        at 
org.apache.curator.framework.imps.NamespaceImpl.fixForNamespace(NamespaceImpl.java:82)
    ```
    
    ```
    java.lang.NoSuchMethodError: 
org.apache.hive.service.auth.HiveAuthFactory.getSocketTransport(Ljava/lang/String;II)Lorg/apache/hive/org/apache/thrift/transport/TTransport;
        at 
org.apache.hive.jdbc.HiveConnection.createBinaryTransport(HiveConnection.java:447)
    ```
    
    Hence, IMO instead of catch -> Exception; we should use catch ->Throwable.
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2175](https://issues.apache.org/jira/browse/ZEPPELIN-2175)
    
    ### How should this be tested?
    Use any incompatible in interpreter dependency, which would throw Error 
instead of Exception.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2175

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2122
    
----
commit 666ce8d3d1b1d9f8abf3dcbb0d8223fdaeb5af86
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date:   2017-03-11T06:01:49Z

    use Throwable instead of Exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to