GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/2146
[HOTFIX][ZEPPELIN-2037][ZEPPELIN-1832] "Restart" button does not work -
branch-0.7
### What is this PR for?
Fixing restarting interpreters work correctly. All restart buttons runs
restarting only user's interpreter instance including "scoped" and "isolated".
If you shutdown the server, Zeppelin terminates all interpreters' processes
This is a branch-0.7 version of #2140
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [x] - Make "Restart" button work properly
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2037
* https://issues.apache.org/jira/browse/ZEPPELIN-1832
### How should this be tested?
1. Enable shiro
1. Login with "admin"
1. Set "Per user" to "scoped"
1. Run "sc.version" in note1 with "admin"
1. Login with "user1"
1. Run "sc.version" in note1 with "user1"
1. Click the "restart" button in note1 page with "admin"
1. Check the process with 'ps aux | grep RemoteInterpreterServer'. Will
find one process
1. Click the "restart" button in note1 page with "user1"
1. Check the process with 'ps aux | grep RemoteInterpreterServer'. Won't
find any process
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2037-branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2146
----
commit bc0ea022ced185ef76c4db163b09548e92682113
Author: Jongyoul Lee <[email protected]>
Date: 2017-03-12T13:55:26Z
WIP
Added unit test for all modes
Fixed dereference bug
commit 6c39bcb1cd0fcfcdc0b0fbd14ab60d39627df21b
Author: Jongyoul Lee <[email protected]>
Date: 2017-03-15T13:43:48Z
Changed the logic of closing interpreter
Changed closing logic of lazyinterpreter to synchronous execution to
guarantee the order of execution
commit 851d60a07874130ac2c71aefbdf0c118afcf91c6
Author: Jongyoul Lee <[email protected]>
Date: 2017-03-15T16:07:24Z
Fixed to remove interpreterGroup if it's empty
commit 44aa9ed84bb8c42cf3a60238f64ce150645c45c8
Author: Jongyoul Lee <[email protected]>
Date: 2017-03-15T16:16:54Z
Fixed test cases
commit ed8fa56ad52e2f9ff079361a87b32e69643862bc
Author: Jongyoul Lee <[email protected]>
Date: 2017-03-15T16:19:23Z
Reverted wrong changes
commit 2999a64c0b051d8f007aa1e7799c8ec538f8921b
Author: Jongyoul Lee <[email protected]>
Date: 2017-03-15T16:23:54Z
Fixed the style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
