GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2148
[branch-0.7][ZEPPELIN-2060] Make dynamic select form turn on or off using
checkbox
### What is this PR for?
This PR is same with #2100 with base branch `branch-0.7`.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes. updated
[dynamicform.md](https://github.com/apache/zeppelin/compare/branch-0.7...AhyoungRyu:branch-0.7/turnOnOrOffAutoRun?expand=1#diff-aba7dc68954cf4c48b87deccf1914bfb)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin
branch-0.7/turnOnOrOffAutoRun
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2148
----
commit 40a1478f21a53214758b3d237b57757e8e22d212
Author: AhyoungRyu <[email protected]>
Date: 2017-03-16T09:12:26Z
[ZEPPELIN-2060] Make dynamic select form turn on or off using checkbox
I added "Auto Run" checkbox for select dynamic form to make user turn on /
off automatic running after the form value changed.
Improvement
* [x] - update docs after getting feedback
[ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060)
1. Apply this patch and run Zeppelin web as dev mode
```bash
$ yarn run dev
```
2. Go to Spark tutorial note and try to change value in select form as
below screenshot imgs
- "Auto Run" checkbox button will be shown only in select dynamic form's
dropdown menu
- _**turn on**_ "Auto Run"-> auto run right after the value changed /
_**turn off**_ -> need to press `Enter`
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes, maybe [this
part](https://github.com/apache/zeppelin/blob/master/docs/manual/dynamicform.md#select-form)
Author: AhyoungRyu <[email protected]>
Closes #2100 from AhyoungRyu/feature/turnOnOrOffAutoRun and squashes the
following commits:
4043579 [AhyoungRyu] Add 'setting: {forms: {}}' info to paragraphMock
47dcb5f [AhyoungRyu] Persist 'runOnSelectionChange' under note.json's
config field
4904f38 [AhyoungRyu] Update dynamicForm docs
66c6c21 [AhyoungRyu] Add test case for behaviour of 'Run on selection
change'
8a0ca30 [AhyoungRyu] Change label to 'Run on selection change'
5075711 [AhyoungRyu] Add a space next to checkbox
f2e3259 [AhyoungRyu] Make dynamic select form turn on or off using checkbox
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
