GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2177
[ZEPPELIN-2301] DON'T overwrite editor text when note is renamed, created,
...
### What is this PR for?
DON'T overwrite local text change in editor when note is renamed, created,
and so on
- `Move up paragraph` and `Move down paragraph` and other actions calling
`saveNote` will reset local text change still. I will resolve it in different
PRs.
#### Implementation Details
We can't get children's `$scope` in angular. That's the reason why
`paragraphText` is written as a (global) service.
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2301](https://issues.apache.org/jira/browse/ZEPPELIN-2301)
Related with
- https://github.com/apache/zeppelin/pull/2120 (different approach)
- https://issues.apache.org/jira/browse/ZEPPELIN-1492 (people are
complaining on this issue. but different topic.)
### How should this be tested?
1. Open the same note in 2 browsers (use different sessions e.g normal
chrome + secret chrome or firefox + safari)
2. Prepare a paragraph synchronized among sessions.
3. Modify text in one browser.
4. (Create, Delete) Rename other notes. The actions which triggering `NOTE`
websocket messages should not overwrite local text change in editor.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2301/should-not-overwirte-local-text-for-note-action
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2177
----
commit 2d79902e2cc3e1dbc2f379dd702469e0ba5e2e63
Author: 1ambda <[email protected]>
Date: 2017-03-22T20:12:26Z
fix: DON'T overwrite local change when note action
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
