[GitHub] zeppelin pull request #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 ...

[soralee]

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2186

    [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7.1

    ### What is this PR for?
    After [[ZEPPELIN-1588]: bumping nvd3 to 1.8.5](#2042) merged, Zeppelin was 
occurring front-end side error such as `Uncaught TypeError: Cannot read 
property 'x' of null` because of upgrading for `1.7.1` to `1.8.5`. 
    AFAIK, this is a bug in `ndv3`, and ndv3 is still fixing the problem 
discussing [here](https://github.com/novus/nvd3/issues/330).
    Also The latest release(1.8.5 version) scatter file and the master scatter 
file have a lot of changes, so we should wait for the next release.
    Thus, I think we need to revert version from 1.8.5 to 1.7.1 for stable 
Zeppelin and our next 0.7.1 release.
    
    _Plus, when I check on current master of nvd3, scatter chart works well 
like this._
    
![z_2229_master_check](https://cloud.githubusercontent.com/assets/8110458/24280800/f1cd4caa-1096-11e7-8d68-bc831d9e228b.gif)
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2229](https://issues.apache.org/jira/browse/ZEPPELIN-2229)
    
    ### How should this be tested?
    * Switch some of chart such like screenshots.
    
    ### Screenshots (if appropriate)
    [Before]
    
![x_of_null_error](https://cloud.githubusercontent.com/assets/8110458/24280810/1ffe2432-1097-11e7-8d25-51237144d4ff.gif)
    
    [After]
    
![z_2229_revert_chart2](https://cloud.githubusercontent.com/assets/8110458/24280802/f7447640-1096-11e7-864f-733d9fd17031.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2229_x_of_null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2186
    
----
commit 7dfdd8c016d57a385eb8a886c1d829b7da169856
Author: soralee <sora0...@zepl.com>
Date:   2017-03-24T04:25:11Z

    [ZEPPELIN-2229] changed scatter and pie charts according to reverted version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---