GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2215

    [ZEPPELIN-2341] Remove -Psparkr build profile 

    ### What is this PR for?
    Currently users who build Zeppelin from source need to include `-Psparkr` 
to use `%r` with embedded local Spark. But it's quite inconvenient to write 
this build profile every time we build i think. So I removed `-Psparkr` and 
make `r` related libraries automatically downloaded when we build Zeppelin like 
I did #2213 
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - remove the rest of `-Psparkr` build profile in 
`dev/create_release.sh`, `dev/publish_release.sh`, and `docs/install/build.md` 
after getting feedback
    
    ### What is the Jira issue?
    [ZEPPELIN-2341](https://issues.apache.org/jira/browse/ZEPPELIN-2341)
    
    ### How should this be tested?
    1. Apply this patch
    2. Build source with below command
    ```
    mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine, 
zeppelin-server, zeppelin-display, spark, spark-dependencies'
    
    ```
    Aftr this step, there will be `R` dir under 
`ZEPPELIN_HOME/interpreter/spark`. Before this PR, only `dep` dir and 
`zeppelin-spark_2.10-0.8.0-SNAPSHOT.jar` is generated without `-Psparkr` build 
profile.
    
    4. Restart Zeppelin. To make sure, run R tutorial note under `Zeppelin 
Tutorial` folder
    
    It should be run successfully without any error
    
    ### Screenshots (if appropriate)
    If we build without `-Psparkr`  
    - before : R related properties are not activated by default in Spark 
interpreter 
    ![screen shot 2017-04-03 at 4 31 49 
pm](https://cloud.githubusercontent.com/assets/10060731/24599560/b952e414-188b-11e7-80db-ac649c869c02.png)
    
     - after 
    
![after](https://cloud.githubusercontent.com/assets/10060731/24599567/bc513a94-188b-11e7-9e93-7abca3428279.png)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin 
ZEPPELIN-2341/includeSparkRByDefault

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2215
    
----
commit a00466c224a1caa8a461137faca81669d15207e7
Author: AhyoungRyu <[email protected]>
Date:   2017-04-03T07:02:12Z

    Remove sparkr build profile in pom files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to