GitHub user AlexanderShoshin opened a pull request:
https://github.com/apache/zeppelin/pull/2233
[MINOR] Add paragraph to note
### What is this PR for?
We need to add an ability of adding custom _Paragraph_ to a _Note_. This
will make it easier to write _Note_ and _Paragraph_ tests. At the moment all
paragraphs are created inside _Note_ class.
This refactoring will allow to write a test for ZEPPELIN-1856 issue.
### What type of PR is it?
[Refactoring]
### Todos
* [ ] - Rename `addParagraph()` -> `addNewParagraph()` and
`insertParagraph()` -> `insertNewParagraph()`. These names will describe what
mathods do: create new paragraph and add it to the note.
* [ ] - Remove duplicated code from `addNewParagraph()` and
`insertNewParagraph()` methods.
* [ ] - Add methods `addParagraph()` and `insertParagraph()`, which receive
a _Paragraph_ instance in parameters and add it to the _Note_.
### Questions:
* Does the licenses files need update? **no**
* Is there breaking changes for older versions? **no**
* Does this needs documentation? **no**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexanderShoshin/zeppelin
add-paragraph-to-note
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2233
----
commit 4391f6babe31083b143a8ae260c5feeea5b919cf
Author: Alexander Shoshin <alexander_shos...@epam.com>
Date: 2017-04-07T08:44:32Z
rename addParagraph() -> addNewParagraph(), insertParagraph() ->
insertNewParagraph()
commit b0b1dd4841096e9090ab08f8ef55dd15c2c44698
Author: Alexander Shoshin <alexander_shos...@epam.com>
Date: 2017-04-07T08:54:50Z
remove duplicated code
commit 676db154139a48a30dfc93ce19ca4937f85bae2c
Author: Alexander Shoshin <alexander_shos...@epam.com>
Date: 2017-04-07T09:02:07Z
added methods addParagraph() and insertParagrepg()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
