[GitHub] zeppelin pull request #2239: Show dialog if owners field set to be empty on ...

[soralee]

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2239

    Show dialog if owners field set to be empty on shiro

    ### What is this PR for?
    This PR is for a showing dialog when note's permission set 
`Readers/Writers` but `Owners` is empty. 
    Currently, after merged #849, if user set `Owners` is empty, it's 
automatically set as the current user.
    So, It would be better to show a dialog before `Owners` is fill with the 
current user because user might think it is not intended. 
    
    Plus, if a user only set `Readers` role, all field(`Writers` and `Owners`) 
role is filled as the current user like below. It's not necessary to our 
because the `Owner` role can read and write note.
    
![not_need_wirters](https://cloud.githubusercontent.com/assets/8110458/24869746/2a77d2da-1e4f-11e7-86a5-794e1aac02d0.gif)
    
    
    ### What type of PR is it?
    [ Improvement ]
    
    
    ### What is the Jira issue?
    * [ZEPPELIN-2206](https://issues.apache.org/jira/browse/ZEPPELIN-2206)
    
    ### How should this be tested?
    1. Turn on shiro.
    2. Set permission `Writers` and `Readers` except `Owner` role.
    3. Check the dialog appears
    
    ### Screenshots (if appropriate)
    [Before]
    * Set `Readers` and `Writers` except `Owners`
    
![zeppelin-2206_auto_shiro_b_1](https://cloud.githubusercontent.com/assets/8110458/24869964/cf382676-1e4f-11e7-8e95-30c149a4aba5.gif)
    
    * Set only 'Writers`
    
![zeppelin-2206_auto_shiro_b_2](https://cloud.githubusercontent.com/assets/8110458/24870112/3821f518-1e50-11e7-9310-fcafd4e26376.gif)
    
    * set only `Readers`; this screen is attached above.
    
    [After]
    * Set `Readers` and `Writers` except `Owners` ( Set only `Writers`; this 
result is same)
    
![zeppelin-2206_auto_shiro_a_1](https://cloud.githubusercontent.com/assets/8110458/24870781/61d8f1c0-1e52-11e7-8faa-38ff4fd64f6f.gif)
    
    * Set only 'Readers`
    
![zeppelin-2206_auto_shiro_a_2](https://cloud.githubusercontent.com/assets/8110458/24870811/76f547ca-1e52-11e7-98b2-f6a5541284ab.gif)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2206_auto_shiro

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2239
    
----
commit 3197647131a78e01f7d358145ed80ff9d7c4e188
Author: soralee <sora0...@zepl.com>
Date:   2017-04-10T09:54:25Z

    show dialog if owners field is empty
    
    add dialog for insufficient privileges
    
    remove dialog for insufficient privileges

commit b0ec2ced4cc9e612889b93507e81f91f096c5df7
Author: soralee <sora0...@zepl.com>
Date:   2017-04-10T16:06:41Z

    remove annotaion

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---