GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/2133

    [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in the MultiBarChart

    ### What is this PR for?
    If using the `multiChartBar`, it often occurs overlap in text. So, this PR 
is for preventing to overlap in text. 
    
    >~~The below is the case what I updated.~~
    ~~1. The xLabel generally show all of the text without rotation (less than 
30).~~
    ~~2. If the xLabel size is over than 30 and less than 80, the xLabel text 
are rotated as 90 degree and displayed.~~
    ~~3. If the xLabel size is over than 80, the xLabel text are disappeared, 
but the tooltip is displayed.~~
    >~~I have made improvements based on my thinking, so I would appreciate to 
give me your feedback.~~
    ~~And if merged this PR, I'll update the feature so that user can use `min` 
and `max` variables by user on web.~~
    
    **[Update]**
    To prevent overlap in xLabel text, in one way which is talked the below 
mentions, user who is using zeppelin could select to visualization type of 
xLabel such as `rotate 45 degree` or `hide`.
    
    ### What type of PR is it?
    [Bug Fix | Improvement ]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1357; UI - label wrapping not done properly in 
charts](https://issues.apache.org/jira/browse/ZEPPELIN-1357)
    * [ZEPPELIN-1892; Display label vertically or horizontally 
smartly](https://issues.apache.org/jira/browse/ZEPPELIN-1892)
    * [ZEPPELIN-1370; Label overlaps - in default visualization example 
barchart](https://issues.apache.org/jira/browse/ZEPPELIN-1370)
    
    ### How should this be tested?
    1. Run the paragraph for bank data in  the `Basic Features (Spark)` 
notebook.
    2. Execute the following query.
    ``` 
    %sql
    select * from bank
    ```
    3. Use the pivot in the `Setting` toggle in the `MultiBarChart` such as the 
screenshots.
    
    ### Screenshots (if appropriate)
    **[Before]**
    
![z_zeppelin-1357_b](https://cloud.githubusercontent.com/assets/8110458/23898303/f80d7bbc-08f3-11e7-9b24-3248c492b8af.png)
    
    
![z_1357_b3_](https://cloud.githubusercontent.com/assets/8110458/23898435/75b3ae60-08f4-11e7-9d7c-31746f0d4edc.png)
    
    **[After]**
    
![update_overlap_in_text](https://cloud.githubusercontent.com/assets/8110458/24888251/f9acc8ce-1e9c-11e7-8a49-a5bcc00c4a29.gif)
    
    
    
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1357_overlap_text

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2133
    
----
commit 67e739c0fc7f6ffbf36812c5c6970feb6e2f1c2f
Author: soralee <sora0...@zepl.com>
Date:   2017-03-14T05:07:44Z

    prevent to overlap in text if using multiBarChart

commit a47804bf2cd443e232ec11fc6cdd3727a83ed5ba
Author: soralee <sora0...@zepl.com>
Date:   2017-03-14T10:28:47Z

    prevent to overlap in text if using multiBarChart

commit e5c7ac6d312913ba4b5b23ab7aafe40f7f6fb3e3
Author: soralee <sora0...@zepl.com>
Date:   2017-03-17T04:35:51Z

    fix typo

commit cd033ff336e0c2cd249ea30bdd36e5af8fade4c2
Author: soralee <sora0...@zepl.com>
Date:   2017-03-17T06:32:52Z

    move to barchart

commit 668702cec76bc920604066d7f6a3b14edada2daa
Author: soralee <sora0...@zepl.com>
Date:   2017-04-03T03:55:19Z

    remove initial defind xlabels

commit 08411326289c89a9773402972faffd2031b72a84
Author: soralee <sora0...@zepl.com>
Date:   2017-04-06T07:30:21Z

    update select visualization xLabel

commit 7ec879c921e1f81c6fd6709c8c8cbeb342b0e8ad
Author: soralee <sora0...@zepl.com>
Date:   2017-04-06T07:35:42Z

    remove xLabel variable

commit c3ececdc3c7c06d216fe55858a796c2afcd838f6
Author: soralee <sora0...@zepl.com>
Date:   2017-04-11T00:51:59Z

    change remove to hide

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to