GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2241

    ZEPPELIN-2390. Improve returnType for z.checkbox

    ### What is this PR for?
    Currently it is not convenient to access the individual item of the return 
value of z.checkbox, I would propose to return `Seq` for `SparkInterpreter` and 
`list` for `PySparkInterpreter`.  This might cause some incompatibility, but I 
think it is acceptable considering the benefits.  Besides that, before this PR, 
all the items of checkbox would be checked by default in `PySparkInterpreter` 
which is inconsistent with `SparkInterpreter`, so I change it to nothing is 
selected by default in this PR. 
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2390
    
    ### How should this be tested?
    Unit test is added
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2390

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2241
    
----
commit 9bb616d95c6d4714d0574374cd314c2c87b3bfa0
Author: Jeff Zhang <zjf...@apache.org>
Date:   2017-04-11T10:09:35Z

    ZEPPELIN-2390. Improve returnType for z.checkbox

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to