[GitHub] zeppelin pull request #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar ...

[1ambda]

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2265

    [ZEPPELIN-2427] Hide navbar and noteAction bar when scrolling down

    ### What is this PR for?
    
    Hide navbar and noteAction bar when scrolling down to 
    
    - **widen view area**
    
    Here are few famous services which hiding their navbar too.
    
    - https://www.kaggle.com/c/titanic
    - https://github.com/1ambda (profile page)
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - Add headroom.js
    * [x] - Filter out useless dependencies
    * [x] - Apply headroom.js
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2427](https://issues.apache.org/jira/browse/ZEPPELIN-2427)
    
    ### How should this be tested?
    
    1. Open Zeppelin
    2. Scroll down, up to see whether navbar and note action bar are hided or 
not.
    
    ### Screenshots (if appropriate)
    
    
![2427](https://cloud.githubusercontent.com/assets/4968473/25214004/afae7a1c-25cf-11e7-9ee1-f41e767d2039.gif)
    
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2265
    
----
commit 0db5f3bde766cd6e27cb6b5f8f8b0badba27f3b1
Author: 1ambda <1am...@gmail.com>
Date:   2017-04-20T04:34:02Z

    feat: Add headroom dep

commit 39e37154ac68a7bedc30a93c7dd66b5f27c805dd
Author: 1ambda <1am...@gmail.com>
Date:   2017-04-20T04:34:22Z

    fix: Filter out useless deps

commit 7b7638803215699815827a3a8d40c8ae1e749370
Author: 1ambda <1am...@gmail.com>
Date:   2017-04-20T04:34:36Z

    feat: Apply headroom.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---