Benoy Antony created ZEPPELIN-2463:
--------------------------------------

             Summary: Avoid Locking interpreterSettings during Notebook deletion
                 Key: ZEPPELIN-2463
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2463
             Project: Zeppelin
          Issue Type: Bug
            Reporter: Benoy Antony
            Assignee: Benoy Antony


Deletion of a notebook requires locking _interpreterSettings_. If the deletion 
is delayed , then lock is  not released. At that point, we cannot run any 
notebook because everything is waiting to lock _interpreterSettings_.

Looking at the code, there is no reason to lock the _InterpreterSettings_ 
object in _InterpreterSettingManager.removeNoteInterpreterSettingBinding_.
Similarly in _InterpreterSettingManager.getNoteInterpreterSettingBinding_  only 
_interpreterSettingBinding_ is accessed and its already a thread safe object. 
So we can remove synchronization on _InterpreterSettings_




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to