GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2352

    [ZEPPELIN-2570] fix: indistinguishable directory icon color

    ### What is this PR for?
    
    Fixed indistinguishable directory icon color. See the attached screenshots.
    
    Problem is that it's hard to
    
    - recognize directory is opened not not
    - distinguish whether it is a note is or a directory
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2570](https://issues.apache.org/jira/browse/ZEPPELIN-2570)
    
    ### How should this be tested?
    
    - Open Directory
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    <img width="203" alt="opened" 
src="https://cloud.githubusercontent.com/assets/4968473/26232541/f7881b94-3c91-11e7-8914-b01c358d781b.png";>
    
    <img width="301" alt="screen shot 2017-05-19 at 12 13 02 pm" 
src="https://cloud.githubusercontent.com/assets/4968473/26232542/f8e1474a-3c91-11e7-891c-84a5d2579f06.png";>
    
    
    #### After
    
    <img width="317" alt="screen shot 2017-05-19 at 12 17 54 pm" 
src="https://cloud.githubusercontent.com/assets/4968473/26232533/ef4eea16-3c91-11e7-831a-084865b126d8.png";>
    
    <img width="553" alt="screen shot 2017-05-19 at 12 35 05 pm" 
src="https://cloud.githubusercontent.com/assets/4968473/26232536/f0cf7d74-3c91-11e7-8b62-2b13f3767ed6.png";>
    
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2570/change-directory-color

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2352
    
----
commit 7079ce34c1c1a63c58d737e62f5d0b738065affc
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-19T03:43:00Z

    feat: Make dir color distingusible

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to