GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2355

    [ZEPPELIN-2573] Improve navbar style

    ### What is this PR for?
    
    Improved navbar style. Refer the screenshots for detail.
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - Fix nav brand text font-size
    * [x] - Fix nav menu text font-weight
    * [x] - Removed icon for search input
    * [x] - Fix bug in notebook menu (focus state remains after it's closed)
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2573](https://issues.apache.org/jira/browse/ZEPPELIN-2573)
    
    ### How should this be tested?
    
    1. Build Zeppelin: ` mvn clean package -DskipTests; 
./bin/zeppelin-daemon.sh restart`
    2. Open the main page
    
    ### Screenshots (if appropriate)
    
    #### Before: Navbar Style
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26277672/20516888-3dc7-11e7-9af1-506e9e581499.png)
    
    #### After: Navbar Style
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26277631/4c01bde4-3dc6-11e7-8ce2-c42fd354c707.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2573/improve-navbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2355
    
----
commit cbe7390934ab651b20ed86a1b211e2a822f3d0b8
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-19T19:29:28Z

    fix: Move navbar related style to navbar.css

commit b936b8a2c75aa550e8f85906e07f7b2d74bb1dcb
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-19T21:28:42Z

    feat: Set font style in navbar

commit 20364dfcb341b42327363b00f0d16a51cb4d5eed
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T14:22:10Z

    fix: Update search input in navbar

commit 55a7aad5ef397a7463bfb515a0c9b3f93ad87bd3
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T14:30:57Z

    fix: Move username related css into navbar

commit 3cbcf952d9ee45e28bcbece258d5bacbebdcc25b
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T14:45:30Z

    fix: DON'T use :focus for notebook menu

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to