GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2358

    [ZEPPELIN-2428] Improve `create new note` dialog style

    ### What is this PR for?
    
    Improve `create new notebook` dialog style. See the attached screenshots.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2428](https://issues.apache.org/jira/browse/ZEPPELIN-2428)
    
    ### How should this be tested?
    
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Run Zeppelin and open browser: `localhost:8080`
    3. `create new notebook` functionality should work as like before.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    #### After
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26282008/cffaf8f0-3e42-11e7-8006-88f542712364.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin improve-create-note-dialog

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2358
    
----
commit dddb5d9ef5371c299c6c8fa62fd2eeaef4cc401a
Author: 1ambda <[email protected]>
Date:   2017-05-21T00:45:07Z

    style: Reformat note-name-dialog.html

commit abe90c6744563f6c362ffe182970505941071663
Author: 1ambda <[email protected]>
Date:   2017-05-21T01:04:43Z

    feat: Style modal-header

commit 774c99eb0b7c342021823690a5d0e07868c1f5f5
Author: 1ambda <[email protected]>
Date:   2017-05-21T01:11:12Z

    feat: style modal-footer for note name dialog

commit c97d68feec2613653e8127745ed323509f671dd9
Author: 1ambda <[email protected]>
Date:   2017-05-21T01:59:45Z

    refactor: format note-name-dialog

commit d6f78d90caa79bb901b50e49b514a541821fa52b
Author: 1ambda <[email protected]>
Date:   2017-05-21T02:07:49Z

    feat: label style for note name dialog

commit 21fa982405b775384055697504dbbac7ed87ad18
Author: 1ambda <[email protected]>
Date:   2017-05-21T02:15:08Z

    feat: Style panel desc

commit 71ed709cc1d6fb72b51d3310f5eb7f5e5cf06e27
Author: 1ambda <[email protected]>
Date:   2017-05-21T02:23:00Z

    feat: Style note name dialog modal-body

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to