GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2469
[ZEPPELIN-2725] Move angular related pkgs from bower to npm (zeppelin-web)
### What is this PR for?
Move angular related packages from bower to npm. Because bower team
recommends using npm (or yarn) instead of bower. It will not be maintained.
For angular-websocket, can't move it to npm currently. As it's tightly
related to node packages like (ws, fs, tls, ...) which are not available in the
browser side. We can solve this problem after applying webpack2+
- https://github.com/AngularClass/angular-websocket/issues/82
### What type of PR is it?
[Improvement]
### Todos
* [x] - Move angular related packages
* [x] - DO NOT use angular as the global dependency
* [x] - remove not used global names from .eslintrc
### What is the Jira issue?
[ZEPPELIN-2726](https://issues.apache.org/jira/browse/ZEPPELIN-2726)
### How should this be tested?
CI will test it, all existing functionalities should work properly.
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2725/use-npm-packages-instead-of-bower
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2469
----
commit 0eabd3442e63ac14b24454400e02d7fe2549c756
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-06T06:09:53Z
fix: move angular related pkgs to npm
commit 80413c93d0439d9b925faa5d75cd5e95bc58c1b8
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-06T06:25:39Z
fix: DON'T use global angular
commit 79f504bf0c2731c71f84638370bc10039713211d
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-06T06:27:42Z
fix: Remove unused global var
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
