GitHub user necosta reopened a pull request:

    https://github.com/apache/zeppelin/pull/2456

    [ZEPPELIN-2714] Soft-code Spark UI button visualization

    ### What is this PR for?
    When "spark.ui.enabled" property is set to "false" we should not show the 
Spark UI button.
    We keep the same behaviour when this property does not exist or when it 
exists and it's set to true.
    
    ### What type of PR is it?
    [ Improvement]
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2714
    
    ### How should this be tested?
    1. Open Zeppelin, go to Interpreter > Spark
    1. Click spark ui > msg: "No spark application running"
    1. Go to a paragraph, run "sc.parallelize(1 to 100).count()", check "SPARK 
JOB" button
    1. Go to Interpreter > Spark > Set "spark.ui.enabled" to "false"
    1. Rerun paragraph > "SPARK JOB" button not visible
    1. Go to Interpreter > Spark > "spark ui" button not visible
    Also, test with "spark.ui.enabled"="true" and other workflow combinations
    
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? N
    * Does this needs documentation? N


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nokia/zeppelin zeppelin2714

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2456
    
----
commit a85864c0168f4fb1ffefde7db2d118cd675c400b
Author: Nelson Costa <[email protected]>
Date:   2017-06-30T09:17:59Z

    [ZEPPELIN-2714] Soft-code Spark UI button visualization

commit 294dea8fbc3452c0caae072d45c60bcc02def069
Author: Nelson Costa <[email protected]>
Date:   2017-07-03T20:38:01Z

    [ZEPPELIN-2714] Improvements to change request

commit edf29cc1ed233497ea89d49dfe53cc863255c0b2
Author: Nelson Costa <[email protected]>
Date:   2017-07-06T10:04:21Z

    [ZEPPELIN-2714] Minor final fix

commit 278a23ee31cd7cc90a587124ca15c53e62af8e45
Author: Nelson Costa <[email protected]>
Date:   2017-07-06T14:04:04Z

    [ZEPPELIN-2714] Fixed broken unit-test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to