GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2493
[ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally, I modified `configuration.html` to add the missing `tbody`. ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2778](https://issues.apache.org/jira/browse/ZEPPELIN-2778) ### How should this be tested? 1. cd `zeppelin-web` 2. `yarn install` (or `npm install`) 3. `yarn run test` (or `npm run test`) The test should pass. ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2778/add-unit-test-for-credential-page Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2493 ---- commit 818d0970d90a5f510075d1791bf6ac04a2494d3d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T14:08:18Z fix: Remove lodash dependency commit cce91f98236daa89ddfbae51aebed4547997fcdc Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T14:14:52Z fix: Remove unused var commit 904e05131eb9abfbbcbd25829b07d6f491878bfb Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:26:21Z refactor: Extract isValidCredential commit 644e49afbbb015ff2b3b60251a0940792247101b Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:27:46Z fix: Add guard to update method commit 0c5a22027b2e019a660da4d24a07210ea4185d0d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:38:33Z refactor: Add showToast commit e857047dffb0382fcce98c525e5b07912a0cd75b Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:39:55Z style: Re-indent commit b4111f89723312c58cfd0843c1bde70c023dd9c9 Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:58:25Z fix: Add missing tbody in credential.html commit 46294be60b54cd3276f4781808bebe150246d58d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T16:01:26Z test: Add credential.test.js ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---