GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/2509

    [ZEPPELIN-2818] Improve to better rendering from jupyter note

    ### What is this PR for?
    Hi, zeppelin community.
    Zeppelin currently has a way to use the Jupiter Note.
    This is a great feature.
    However, I have found that there are some problems with the way of showing.
    I've improved this to increase the user experience.
    Please check the screenshot for details.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] added pre-render feature (markdown).
    - [x] increased to many support type for output data.
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2818
    
    ### How should this be tested?
    1. build jupyter module
      `mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am`
    2. `cd zeppelin-jupyter/target`
    3. `java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar 
org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file 
path!/getting_started.ipynb`
    4. get a `note.json` and import to zeppelin on frontend!
    5. enjoy
    
    ### Screenshots (if appropriate)
    #### Before
    
![oldold](https://user-images.githubusercontent.com/10525473/28717881-8c176d40-73de-11e7-9a67-732808957391.gif)
    
    #### After
    
![zeppelin-from-jupyternote](https://user-images.githubusercontent.com/10525473/28717782-1fa90f4c-73de-11e7-8d9c-f5191d8f8a47.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2818

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2509
    
----
commit 6ce9935b9a919757d4d8f6bd1cdd6fa62d341282
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2017-07-28T09:24:34Z

    improving get output part

commit 4a51586036bfab9db38bd481d134f06ed3bf59c6
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2017-07-28T10:33:39Z

    implement markdown pre render

commit a56b6ffc65a70bdc39c23695133df89e747ef9e8
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2017-07-28T10:39:05Z

    fix checkstyle

commit 1e15581d1a5b335d776f56f19f330a5587505934
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2017-07-28T12:19:01Z

    improving reder feature

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to