GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2512
[ZEPPELIN-2823] Notebook saved status is wrong if there was a network
disconnect or a flaky network.
### What is this PR for?
Notebook content doesn't get saved if there is a flaky network, and at
times user's paragraph content also gets lost in this process.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2823](https://issues.apache.org/jira/browse/ZEPPELIN-2823)
### How should this be tested?
Steps to re-produce:
- create a new notebook
- in the first paragraph enter text, say "version1"
- now disconnect the network (say by removing LAN cable)
- update this paragraph again with text "version2"
- reconnect network
- now observe the on the WebSocket reconnect, the content of this
paragraph will go back to "version1"
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need an update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2823
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2512
----
commit d2a835f7785159833e2a00cf519f1c95fcc87c24
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date: 2017-08-02T00:35:03Z
wait for server confirmation before updating stats of notebook
commit 8b8c2f97415f49d839a266caaa10de0c7b89fce3
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date: 2017-08-02T22:39:49Z
check for empty originalText
commit 947be70b41279c572257353d9536f3e8fecc6a4e
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date: 2017-08-03T14:34:24Z
check if noteId exists in session or take it from fromMessage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
