[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[herval]

Github user herval commented on the issue:

    https://github.com/apache/zeppelin/pull/2503
  
    Hmm It shouldn’t work without the Cookie manager. The checkbox will still 
show, though, which begs the question if it should be a default? (Otherwise 
we’ll have to hide the checkbox based on some shiro config)
    
    ________________________________
    From: Kun <notificati...@github.com>
    Sent: Friday, August 4, 2017 7:24:19 PM
    To: apache/zeppelin
    Cc: Herval Freire; Author
    Subject: Re: [apache/zeppelin] [ZEPPELIN-2808] remember me support (#2503)
    
    
    @1ambda commented on this pull request.
    
    ________________________________
    
    In 
conf/shiro.ini.template<https://github.com/apache/zeppelin/pull/2503#discussion_r131512560>:
    
    > @@ -46,6 +46,12 @@ user3 = password4, role2
     #ldapRealm.userDnTemplate = uid={0},ou=Users,dc=COMPANY,dc=COM
     #ldapRealm.contextFactory.authenticationMechanism = simple
    
    +### If you want "remember me" to keep used logged in between sessions
    
    
    Hi, without enalbing these lines, remember me feature works. Is it intended?
    
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/zeppelin/pull/2503#pullrequestreview-54506236>,
 or mute the 
thread<https://github.com/notifications/unsubscribe-auth/AAAV6lPF0-F6K1GJDFMHV_1RElwPb64Yks5sU9JTgaJpZM4OjEhR>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---