GitHub user BruceXu1991 opened a pull request:

    https://github.com/apache/zeppelin/pull/2601

    [ZEPPELIN-2956] [font-end] Downloaded CSV/TSV data will get unexpected 
division when the column value contains both delimiter and quotation mark.

    ### What is this PR for?
    Fix for ZEPPELIN-2956. This PR is to deal with the case when column value 
contains both delimiter and quotation mark. So the downloaded data can be well 
recogized and seperated by Excel.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    None
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2956
    
    ### How should this be tested?
    Manual test.
    After applying this PR, you can test the patch as following steps:
    1、suppose one of the column value contain both  delimiter and quotation 
mar:  
    eg: hello  beijing  i  lo"v,"e  you
    2、download the data as csv/tsv file
    3、open the data file through Excel
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    no
    * Is there breaking changes for older versions?
    no
    * Does this needs documentation?
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceXu1991/zeppelin fix_csv_tsv_download_bug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2601
    
----
commit d9485bd7a8d4ccce712d7ac2de31dcbb3173caba
Author: xu.wenchun <xu.wenc...@immomo.com>
Date:   2017-09-27T10:28:07Z

    fix bug: Excel can't seperate csv/tsv data well

----


---

Reply via email to