GitHub user namanmishra91 opened a pull request:
https://github.com/apache/zeppelin/pull/2619
Run all paragraphs sequentially
### What is this PR for?
This PR introduces "run all" behaviour for a note in a sequential manner.
The "Run All paragraphs" button will now run the notebook sequentially. There
is a UX change as part of this PR, which is discussed below. Any suggestions to
make it better are welcome.
Following is the approach taken in brief:
- Replace the behaviour of "Run All paragraphs" to "Run All sequentially"
- Submit paragraphs to the respective scheduler only after the previous one
completes execution (via wait-notify mechanism)
- Communicate the status of the sequential run to client over websocket
- Since the paragraphs won't be submitted immediately, changing their
status is a challenge while keeping the code maintaining it at one place.
Therefore, the approach I have taken is to keep the status of the paragrahs
as-is and disallow explicit run of individual paragraphs when sequential run is
in progress (see GIF for details).
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2368
### How should this be tested?
* Have a notebook with different interpreter types (e.g. sh, md, spark etc.)
* Click "Run All paragraphs"
* The paragraphs should run sequentially
* While sequential run is in progress, explicit run of paragraphs should
not be allowed
* Correct sequential run state should be communicated to the browser when
note is loaded
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? Probably not, but the UX
would be different
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/namanmishra91/zeppelin ZEPPELIN-2368
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2619
----
commit 4a6f9d19b5ba846bf8f205ec57a1649f5416a0ce
Author: Naman Mishra <[email protected]>
Date: 2017-07-28T11:07:57Z
Backend changes for sequential run of paragraphs
commit 5fc5c8390bf6c43009746b415334327ae2382c43
Author: Naman Mishra <[email protected]>
Date: 2017-10-10T09:50:28Z
Backend + UI changes
commit fdd1baeb10cc856ad3928cb7a35116172c14ea84
Author: Naman Mishra <[email protected]>
Date: 2017-07-28T11:07:57Z
Backend changes for sequential run of paragraphs
commit 8ef73408ad4addee1979ffc52fe3bdbd2fc93bd6
Author: Naman Mishra <[email protected]>
Date: 2017-10-10T09:50:28Z
Backend + UI changes
commit a51a3e8fd76d9293f8479e085b002352e2f3ac99
Author: Naman Mishra <[email protected]>
Date: 2017-10-10T10:01:00Z
Merge branch 'ZEPPELIN-2368' of https://github.com/namanmishra91/zeppelin
into ZEPPELIN-2368
commit 63e7e521ca82d259278e40c88764df67b1c870ff
Author: Naman Mishra <[email protected]>
Date: 2017-10-10T10:15:25Z
Clean up logs
----
---
