[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...

Wed, 01 Nov 2017 00:38:10 -0700 

GitHub user jinxliu reopened a pull request:

    https://github.com/apache/zeppelin/pull/2634

    [ZEPPELIN-3014] NPE bug fix and Error message enhancement with Kylin 
Interpreter

    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3014
    
    ### How should this be tested?
    *  Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Use existing unit tests in kylin module.
    
    ### Screenshots (if appropriate)
    
    #### before: NPE when result set is empty
    
![image](https://user-images.githubusercontent.com/18542573/32154048-f1b8ba58-bcfb-11e7-98cc-98cdf484f2d5.png)
    #### after: no NPE when result set is empty, just an empty table
    
![image](https://user-images.githubusercontent.com/18542573/32154069-110215d0-bcfc-11e7-87e9-cc049001f1c7.png)
    
    #### before: when query fails, only error code is returned, no error message
    
![image](https://user-images.githubusercontent.com/18542573/32154088-29651938-bcfc-11e7-9e66-cd2cfccba054.png)
    #### after: when query fails, both error code and error message are 
displayed to users
    
![image](https://user-images.githubusercontent.com/18542573/32154096-3d3ab01c-bcfc-11e7-8cf3-d710d96b8c5a.png)
    
    
    
    ### Questions:
    * Does the licenses files need update? No.
    * Is there breaking changes for older versions? No.
    * Does this needs documentation? No.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinxliu/zeppelin kylin-intp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2634
    
----
commit ec68d12437611dd6fb817fa058020bb926b7e163
Author: Liu <[email protected]>
Date:   2017-10-27T06:05:39Z

    enhance kylin interpter, add error message parse

commit cadaa2b9877da39d96db6b2e06f4169c9f604caf
Author: Liu <[email protected]>
Date:   2017-10-27T07:03:26Z

    NPE bug fix when returned result set is empty

commit c1ec9e72ec7c74c75011e2abf37a9563d1af7056
Author: jinxliu <[email protected]>
Date:   2017-10-27T07:56:09Z

    Merge pull request #1 from apache/master
    
    merge recent changes

commit 933c9d872e67d64d9e646cb287a66f2d7593a54a
Author: Liu <[email protected]>
Date:   2017-10-31T05:45:48Z

    use gson

commit a45a3b4bdbef4aff2f743a461c29ea435125c895
Author: Liu <[email protected]>
Date:   2017-10-31T05:46:55Z

    Merge branch 'kylin-intp' of https://github.com/jinxliu/zeppelin into 
kylin-intp

commit 531318cdf8974d80ee4ff4c659c4fb29bfae91ef
Author: jinxliu <[email protected]>
Date:   2017-10-31T06:34:31Z

    Merge pull request #2 from apache/master
    
    keep up to date with apache master branch

----


---

Reply via email to