GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2615
[ZEPPELIN-1999][IMPROVEMENT] refactoring replacement context parameters
into interpreter settings
### What is this PR for?
Field `protected Properties property` is protected. sometimes this field
used derictly. Sometimes interpreter is called from another insterpreter (for
ex. Spark, SparkInterpreter creates spark context and calls PySpark). This
improvement fix it problems with context parameters replacement into properties.
### What type of PR is it?
Improvement
### How should this be tested?
1) Setting Spark interpreter
set property 'spark.app.name=#{noteId}'
2) Run paragraph
```%pyspark
print(sc._conf.get("spark.app.name"))
```
3) Check result (note id)
4) Open http://localhost:4040/environment/ (spark ui), check property
`spark.app.name` = note id
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-1999-FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2615
----
commit 2447adcd6cb06ddf674ed19013c7464266eeabac
Author: tinkoff-dwh <[email protected]>
Date: 2017-09-14T11:47:12Z
[ZEPPELIN-1999-fix] fix replace parameters. add integrations tests
commit 00725bf4f9aa26c3cbf2c20ee3fffd7094b99c9c
Author: tinkoff-dwh <[email protected]>
Date: 2017-09-17T11:16:29Z
[ZEPPELIN-1999-fix] fix replace parameters
commit 42590c914afbc169ec75af4c3a809f6e3f27eb43
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-10T14:29:53Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1999-FIX
commit 683b3c1e1258d56399dc48e0bf3a10de66f0c83d
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-10T15:29:02Z
[ZEPPELIN-1999-FIX] fix tests
commit b4e5a3da8c6ae4b44f1666b72d79a39a8d76aa1a
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-14T16:22:14Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1999-FIX
# Conflicts:
# jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
#
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/Interpreter.java
commit adf980bd7348aaf8d4d1c544dad6af2e7f680ad3
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-14T16:24:45Z
[ZEPPELIN-1999-FIX] rename method
commit 24097c56115bb7342ad6d6c76e7aa67d98faa10f
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-14T16:32:11Z
[ZEPPELIN-1999-FIX] fix call method
commit f283d0772f94eea8ddd087287e7318e34cc1d5f3
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-14T17:37:55Z
[ZEPPELIN-1999-FIX] fix tests
commit 83554b43397382715a8ba10af450c242b48d2ae6
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-14T17:51:06Z
[ZEPPELIN-1999-FIX] fix JDBCInterpreter
commit acef59c1421fd8646379338e0ecea66bcd1cb277
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-30T06:25:11Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1999-FIX
# Conflicts:
#
zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterTest.java
commit 60d872979e76668ed5dcb2dbff574bb1dde37edd
Author: tinkoff-dwh <[email protected]>
Date: 2017-11-06T12:20:22Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1999-FIX
# Conflicts:
#
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
commit c0ec13970ddbe249536768fbc7116a0e36a06c96
Author: tinkoff-dwh <[email protected]>
Date: 2017-11-29T17:36:41Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1999-FIX
# Conflicts:
#
zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/InterpreterTest.java
commit e7cee53cc78811ee4e3eceea461f55c1b816a763
Author: tinkoff-dwh <[email protected]>
Date: 2017-11-29T19:38:46Z
fix test
commit b1ab3dec8701b0aedab6d2ed15863a744ee8d064
Author: tinkoff-dwh <[email protected]>
Date: 2017-11-30T06:03:27Z
fix test
----
---
