+1 for non-delay merging. Our team have opened approved PR [1] for 5 days. I didn't find any pages with `consensus how to review and merge contributions`. It would be nice to write a check list for reviewer.
The development of Zeppelin is very important for us and we want to review new commits. [1] https://github.com/apache/zeppelin/pull/2697 Thanks, Maksim Belousov -----Original Message----- From: Jongyoul Lee [mailto:jongy...@gmail.com] Sent: Monday, December 18, 2017 12:12 PM To: dev <dev@zeppelin.apache.org> Subject: Re: [DISCUSS] Review process Thank you for the replying it. I think so On Mon, Dec 18, 2017 at 3:15 PM, Miquel Angel Andreu Febrer < miquelangeland...@gmail.com> wrote: > I agree, ig is necessary to have no delay afternoon merging. I think > it will help speed up processes and help contributors > > El 18 dic. 2017 4:33, "Jongyoul Lee" <jongy...@gmail.com> escribió: > > Hi committers, > > I want to suggest one thing about our reviewing process. We have the > policy to wait for one-day before merging some PRs. AFAIK, It's > because we reduce mistakes and prevent abuses from committing by owner > without reviewing it concretely. I would like to change this policy to > remove delay after merging it. We, recently, don't have much reviewers > and committers who can merge continuously, and in my case, I, > sometimes, forget some PRs that I have to merge. And I also believe > all committers have consensus how to review and merge contributions. > > How do you think of it? > > JL > > -- > 이종열, Jongyoul Lee, 李宗烈 > http://madeng.net > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
