GitHub user karth295 reopened a pull request:

    https://github.com/apache/zeppelin/pull/2738

    [ZEPPELIN-3182] Support saving notebooks to Google Cloud Storage

    ### What is this PR for?
    
    Support saving notebooks to Google Cloud Storage, similar to 
implementations for S3 and Azure. It uses the same authentication mechanisms as 
the BigQuery interpreter.
    
    I am new to Maven, so please check my work on the pom.xml files. In 
particular, I upgraded Guava to 23.0, which was required for 
`google-cloud-java`. Going through hello-world with my changes seems to work.
    
    Also, I modified the BigQuery interpreter docs to point to the **latest** 
GCS storage docs. Is it more appropriate to pin to the version you are viewing? 
How can I do that?
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [Low priority] Support encryption keys
    
    I don't this is particularly important, at least for v1.
    
    ### How should this be tested?
    * I added unit tests for the core functionality
    * I manually tested the authentication instructions (but that could use a 
second pair of eyes)
    
    ### Questions:
    * Does the licenses files need update?
      * No idea. `google-cloud-java` is Apache 2: 
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/LICENSE
    * Is there breaking changes for older versions?
      * Nope.
    * Does this needs documentation?
      * Yes, and I tried to update the docs (but there are likely other things 
that need to be updated)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karth295/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2738
    
----
commit 8dc819ee4a322d3616f82f6c720eac221fc32ea0
Author: Karthik Palaniappan <karthikpal@...>
Date:   2018-01-29T03:10:40Z

    Unify logic to clear notebook runtime state on load from storage

commit 68b1693568e49e15d47a1d597a97cb5ee70805be
Author: Karthik Palaniappan <karthikpal@...>
Date:   2018-01-29T03:21:34Z

    [ZEPPELIN-3182] Support saving notebooks to Google Cloud Storage

----


---

Reply via email to