GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2804
[ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript) ## What is this PR for? Have added this PR to add a rule in eslinerc to have semicolons in javascript source ### What type of PR is it? [Improvement | Refactoring] ### What is the Jira issue? * [ZEPPELIN-3245](https://issues.apache.org/jira/browse/ZEPPELIN-3245) ### How should this be tested? ``` cd zeppelin-web npm install (or yarn install if you have yarn) npm run lint:once ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin discuss/eslint_semi_rule Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2804.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2804 ---- commit e7062d70529671a8def8dfc3eb144ff4ffe074fd Author: Prabhjyot Singh <prabhjyotsingh@...> Date: 2018-02-15T06:46:25Z add `"semi": [2, "always"]` rule in eslinerc Change-Id: If0356e494152c1beb8b8cef666c95d448a490749 commit 3a133f48bc7824858f02841a1ba81100977a50df Author: Prabhjyot Singh <prabhjyotsingh@...> Date: 2018-02-19T09:28:11Z remove "standard" from eslint Change-Id: If488e5a7faf68fea9c0f463de7aba1dae0607b0d commit 9a43465535a87cb156cc9ab8007fbb17b910e7d2 Author: Prabhjyot Singh <prabhjyotsingh@...> Date: 2018-02-19T09:31:06Z remove `"linebreak-style": 0,` and `"no-use-before-define": 0,` Change-Id: If9727c13bf40be52cbe40b5c7c888c99af739e9b commit a5c9db67acdfe25de712dee09ace5765fdfc45ee Author: Prabhjyot Singh <prabhjyotsingh@...> Date: 2018-02-21T18:37:40Z fix failing WEB_E2E="true" Change-Id: I8af5179afcd63377a4bd76486f7e30e29a97a30b ---- ---