GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/3246
ZEPPELIN-3892 Make SecurityUtils as a service
### What is this PR for?
Making SecurityService more configurable. Currently, SecurityUtils consists
of static methods, and which means it's not extendable and pluggable. It would
be better if users could implement new security features easily.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Introduce `SecurityService` as an interface to support security
features
* [x] - Move `SecurityUtils` to `ShiroSecurityService` as an implementation
of `SecurityService`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3892
### How should this be tested?
* This is a refactoring. It should pass all of the current tests
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3892
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3246
----
commit c5022b2cc1559eabca1bd647fd0ff1a004644198
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T01:53:53Z
Introduce an interface of SecurityService to handle issues of securities
Change SecurityUtils to ShiroSecurityService
Introduce NoSecurityService to divide to handle without shiro configuration
commit 37a00d08080944ef7e9abbb09fa9fe9b7bdb7ebc
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T01:56:34Z
Add licenses
commit f253cf4986ae0a902f0664e0a3c9db9242a00888
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T02:06:12Z
Move validation logic for shiro to ShiroSecurityService
commit ca72b2040b85f35c61e8d250bc61cb80f33d3589
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T02:25:36Z
Add license
commit 74d5d653378afbdc007c65be379920855d49701b
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T13:30:25Z
Change ShiroSecurityService to SecurityService
commit dab7e64a8ead41d38e9f2312814f6286dac7bddb
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T13:36:47Z
Extract two more methods to the interface
commit 70cfb04d56c0f9ec682f70e48fe9cf1f5687a617
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T14:36:34Z
Fix injection information
----
---
