felixcheung commented on a change in pull request #3282: [ZEPPELIN-3944] Update 
Dockerfiles of spark_standalone and spark_yarn_cluster
URL: https://github.com/apache/zeppelin/pull/3282#discussion_r247303861
 
 

 ##########
 File path: scripts/docker/spark-cluster-managers/spark_yarn_cluster/Dockerfile
 ##########
 @@ -52,7 +52,7 @@ ENV HADOOP_MAPRED_HOME /usr/local/hadoop
 ENV HADOOP_YARN_HOME /usr/local/hadoop
 ENV HADOOP_CONF_DIR /usr/local/hadoop/etc/hadoop
 
-RUN sed -i '/^export JAVA_HOME/ s:.*:export 
JAVA_HOME=/usr/lib/jvm/jre-1.7.0-openjdk.x86_64\nexport 
HADOOP_PREFIX=/usr/local/hadoop\nexport HADOOP_HOME=/usr/local/hadoop\n:' 
$HADOOP_PREFIX/etc/hadoop/hadoop-env.sh
+RUN sed -i '/^export JAVA_HOME/ s:.*:export 
JAVA_HOME=/usr/lib/jvm/jre-1.7.0-openjdk-1.7.0.201-2.6.16.1.el7_6.x86_64\nexport
 HADOOP_PREFIX=/usr/local/hadoop\nexport HADOOP_HOME=/usr/local/hadoop\n:' 
$HADOOP_PREFIX/etc/hadoop/hadoop-env.sh
 
 Review comment:
   `1.7.0-openjdk-1.7.0.201-2.6.16.1.el7_6.x86_64\` might not work - this 
changes when `yum install -y java-1.7.0-openjdk-devel` is picking up a newer 
version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to