felixcheung commented on a change in pull request #3179: [ZEPPELIN-3773] - add
check permission on write.
URL: https://github.com/apache/zeppelin/pull/3179#discussion_r247304838
##########
File path: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
##########
@@ -1126,6 +1129,7 @@ function ParagraphCtrl($scope, $rootScope, $route,
$window, $routeParams, $locat
$scope.$on('editorSetting', function(event, data) {
if (paragraph.id === data.paragraphId) {
deferred.resolve(data);
+ $scope.editor.setReadOnly(!$scope.userHasWritePermission());
Review comment:
I worry this would leave it in an inconsistent state - UI showing the
changed value, but it isn't saved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
